Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git hook #822

Merged
merged 51 commits into from
Oct 25, 2022
Merged

Git hook #822

merged 51 commits into from
Oct 25, 2022

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Oct 24, 2022 •
edited
Loading

Closes #x

Proposed Changes

  • Add script to be used on git commit to check for .only() in test files and display error message if there are any

TODO

  • update change log

Potential followups

sczembor
sczembor commented Oct 24, 2022
View reviewed changes
@sczembor
Copy link
Contributor Author

This is how the output in console looks if we leave any .only in js or ts files
Screenshot 2022-10-24 at 16 29 16
All the files are displayed at once when trying to git commit

@thdailong
Copy link
Contributor

This is how the output in console looks if we leave any .only in js or ts files Screenshot 2022-10-24 at 16 29 16 All the files are displayed at once when trying to git commit

@sczembor Is it possible if we can show the line that contain only() in file?

sczembor
sczembor commented Oct 25, 2022
View reviewed changes
@sczembor sczembor merged commit fe42a6d into develop Oct 25, 2022
@sczembor sczembor deleted the git_hook branch October 25, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@rmeena840 rmeena840 rmeena840 approved these changes

@thdailong thdailong thdailong approved these changes

@ratik21 ratik21 Awaiting requested review from ratik21

@vuvoth vuvoth Awaiting requested review from vuvoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sczembor @thdailong @robert-zaremba @rmeena840